Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove branded assets #49

Merged
merged 9 commits into from
Oct 18, 2023
Merged

Remove branded assets #49

merged 9 commits into from
Oct 18, 2023

Conversation

svienot
Copy link
Contributor

@svienot svienot commented Oct 18, 2023

Description:

Remove branded assets from repository: product logo & link to terms-of-service.

These now need to be configured by providing the corresponding URLs in config.json with 2 new properties

    "BRAND_PRODUCT_LOGO_URL": "<URL of logo",
    "TERMS_OF_SERVICE_URL": "<URL of terms-of-service",

By default:

  • Hedera logo / text is used
  • No link to terms-of-service is displayed

See below default and customised variants:

Screenshot 2023-10-18 at 13 24 10 Screenshot 2023-10-18 at 13 25 28

@Nana-EC Nana-EC added this to the 0.1.0 milestone Oct 18, 2023
@Nana-EC Nana-EC added Improvement Code changes driven by non business requirements P1 High priority issue. Required to be completed in the assigned milestone. labels Oct 18, 2023
Nana-EC
Nana-EC approved these changes Oct 18, 2023
View reviewed changes
Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG
I think the HASHSCAN_URL should be defaulted to local also but not sure if you want to tackle that in a follow up PR

ui/public/config.json Outdated Show resolved Hide resolved
@svienot svienot merged commit 19bc83a into main Oct 18, 2023
2 checks passed
@svienot svienot deleted the remove-branded-assets branch October 18, 2023 18:47
@acuarica acuarica mentioned this pull request Apr 5, 2024
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nana-EC Nana-EC Nana-EC approved these changes

@ericleponner ericleponner Awaiting requested review from ericleponner

Assignees

@svienot svienot

Labels
Improvement Code changes driven by non business requirements P1 High priority issue. Required to be completed in the assigned milestone.
Projects
Smart Contract Sprint Board
Archived in project
Milestone
0.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@svienot @Nana-EC